Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOCART] update to gocart hash f7b34e - important updates for FENGSHA #1922

Merged
merged 17 commits into from
Oct 26, 2023
Merged

[GOCART] update to gocart hash f7b34e - important updates for FENGSHA #1922

merged 17 commits into from
Oct 26, 2023

Conversation

bbakernoaa
Copy link
Collaborator

@bbakernoaa bbakernoaa commented Sep 25, 2023 •
edited by FernandoAndrade-NOAA
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests: atmaero_control_p8 atmaero_control_p8_rad atmaero_control_p8_rad_micro
Tests effected by changes in this PR: 
001 cpld_control_p8_mixedmode_intel failed in check_result
007 cpld_control_p8_intel failed in check_result
009 cpld_control_qr_p8_intel failed in check_result
011 cpld_2threads_p8_intel failed in check_result
012 cpld_decomp_p8_intel failed in check_result
013 cpld_mpi_p8_intel failed in check_result
014 cpld_control_ciceC_p8_intel failed in check_result
015 cpld_control_c192_p8_intel failed in check_result
017 cpld_bmark_p8_intel failed in check_result
021 cpld_debug_p8_intel failed in check_result
025 cpld_control_p8_faster_intel failed in check_result
178 atmaero_control_p8_intel failed in check_result
179 atmaero_control_p8_rad_intel failed in check_result
180 atmaero_control_p8_rad_micro_intel failed in check_result
240 cpld_control_p8_gnu failed in check_result
242 cpld_debug_p8_gnu failed in check_result
001 cpld_control_p8_mixedmode_intel failed in check_result
007 cpld_control_p8_intel failed in check_result
009 cpld_control_qr_p8_intel failed in check_result
011 cpld_2threads_p8_intel failed in check_result
012 cpld_decomp_p8_intel failed in check_result
013 cpld_mpi_p8_intel failed in check_result
014 cpld_control_ciceC_p8_intel failed in check_result
015 cpld_control_c192_p8_intel failed in check_result
017 cpld_bmark_p8_intel failed in check_result
021 cpld_debug_p8_intel failed in check_result
025 cpld_control_p8_faster_intel failed in check_result
178 atmaero_control_p8_intel failed in check_result
179 atmaero_control_p8_rad_intel failed in check_result
180 atmaero_control_p8_rad_micro_intel failed in check_result
240 cpld_control_p8_gnu failed in check_result
242 cpld_debug_p8_gnu failed in check_result

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@bbakernoaa bbakernoaa changed the title update to gocart hash f7b34e - important updates for FENGSHA [GOCART] update to gocart hash f7b34e - important updates for FENGSHA Sep 25, 2023
@bbakernoaa
Copy link
Collaborator Author

Ran the atmaero_control_p8 test. The test failed but did complete. We do expect changes with the result.

@bbakernoaa bbakernoaa mentioned this pull request Sep 26, 2023
Merged
@bbakernoaa bbakernoaa marked this pull request as ready for review September 26, 2023 19:53
@climbfuji climbfuji mentioned this pull request Sep 27, 2023
Merged
43 tasks
@bbakernoaa
Copy link
Collaborator Author

@rmontuoro @junwang-noaa If #1920 is going to be delayed I suggest that we push this through as its critical for the EP5 experiments

@bbakernoaa
Copy link
Collaborator Author

just re-synced and so this should be ready @junwang-noaa @DeniseWorthen @rmontuoro

@zach1221
Copy link
Collaborator

zach1221 commented Oct 24, 2023 •
edited
Loading

@bbakernoaa do you have the RegressionTests_hera.log available for the run against this PR? It looks like 1920 will be held a bit longer and we think it would be best to move forward with this PR.

Edit: hera logs attached now.

@zach1221 zach1221 added the Baseline Updates Current baselines will be updated. label Oct 24, 2023
@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Oct 25, 2023
@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA FYI: we started working on this pr.

@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs failed

lipan-NOAA
lipan-NOAA approved these changes Oct 25, 2023
View reviewed changes
GOCART Show resolved Hide resolved
@bbakernoaa
Copy link
Collaborator Author

@bbakernoaa do you have the RegressionTests_hera.log available for the run against this PR? It looks like 1920 will be held a bit longer and we think it would be best to move forward with this PR.

Edit: hera logs attached now.

Thanks. I did not have them attached.

@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs failed

@zach1221
Copy link
Collaborator

Jenkins-ci ORTs failed

Working on this. Instances are not starting up it seems.

@BrianCurtis-NOAA
Copy link
Collaborator

BrianCurtis-NOAA commented Oct 25, 2023 •
edited
Loading

@bbakernoaa I wanted to warn you about using the same name of the auth branch in your merge branch from your personal fork, we typically recommend a unique name to your branch. Maybe gocart_fengsha for example.

It's not going to break anything but has higher potential for issues. No need to change anything, just an FYI.

@zach1221
Copy link
Collaborator

Testing is complete. @BrianCurtis-NOAA @SadeghTabas-NOAA @jkbk2004 . Final review requests have been sent to you.

@zach1221 zach1221 merged commit 63a43d9 into ufs-community:develop Oct 26, 2023
@bbakernoaa
Copy link
Collaborator Author

@BrianCurtis-NOAA Understood. It was a mistake and I just never went back to fix it. I'll make sure I don't repeat this mistake again.

@WalterKolczynski-NOAA WalterKolczynski-NOAA mentioned this pull request Oct 26, 2023
Merged
7 tasks
@grantfirl grantfirl mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipan-NOAA lipan-NOAA lipan-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@junwang-noaa junwang-noaa Awaiting requested review from junwang-noaa

@JessicaMeixner-NOAA JessicaMeixner-NOAA Awaiting requested review from JessicaMeixner-NOAA

@SadeghTabas-NOAA SadeghTabas-NOAA Awaiting requested review from SadeghTabas-NOAA

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bbakernoaa @zach1221 @jkbk2004 @epic-cicd-jenkins @BrianCurtis-NOAA @lipan-NOAA @FernandoAndrade-NOAA